SecurityListView: Properly show short holdings for "Shares held != 0" filter #4500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… filter Don't forcibly clamp negative (short) holdings to zero. However, add comment that the calculation is still not entirely correct, as it may return 0 in case one account have positive number of shares, and another - same number, but negative amount of shares.
|
@buchen : I would like to make some steps towards (better) support short positions. It's hard, because full short support is of course very distant, and it's hard to see where even to start. Well, could start with small things, where there're ungrounded, arbitrary restrictions not compatible with short positions, like here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't forcibly clamp negative (short) holdings to zero. However, add comment that the calculation is still not entirely correct, as it may return 0 in case one account have positive number of shares, and another - same number, but negative amount of shares.