Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a feature to remove empty .janno columns with rectify #326

Merged
merged 13 commits into from
Jan 14, 2025

Conversation

nevrome
Copy link
Member

@nevrome nevrome commented Jan 3, 2025

I started to think about #298 and realized rectify doesn't touch .janno files at all so far. So I thought I first add a simpler .janno-editing feature: Removing empty columns. That is also a pretty common task. Maybe one day rectify will rather be modify 🤔

@nevrome nevrome requested a review from stschiff January 3, 2025 10:28
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 59.67%. Comparing base (eea7cf9) to head (7178a93).

Files with missing lines Patch % Lines
src/Poseidon/CLI/Rectify.hs 60.00% 3 Missing and 1 partial ⚠️
src/Poseidon/CLI/OptparseApplicativeParsers.hs 0.00% 3 Missing ⚠️
src/Poseidon/Janno.hs 94.11% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #326   +/-   ##
=======================================
  Coverage   59.66%   59.67%           
=======================================
  Files          29       29           
  Lines        4349     4364   +15     
  Branches      498      499    +1     
=======================================
+ Hits         2595     2604    +9     
- Misses       1256     1261    +5     
- Partials      498      499    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stschiff stschiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. I haven't tested it, but the unit tests look convincing. I left a few comments about the empty-string to "n/a" feature.

@nevrome
Copy link
Member Author

nevrome commented Jan 9, 2025

I found a better solution for explicitNA. This operates more upstream, thus also affecting the output of list. Please have another look.

@nevrome nevrome requested a review from stschiff January 13, 2025 15:37
Copy link
Member

@stschiff stschiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, this looks all good! Thanks. I think I'd now also like to add a feature in list to skip empty columns.

@nevrome nevrome merged commit eb024c7 into master Jan 14, 2025
2 checks passed
@nevrome nevrome deleted the beefuprectify branch January 14, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants