-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a feature to remove empty .janno columns with rectify #326
Conversation
…noFileWithoutEmptyCols
…ack out of the janno module
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #326 +/- ##
=======================================
Coverage 59.66% 59.67%
=======================================
Files 29 29
Lines 4349 4364 +15
Branches 498 499 +1
=======================================
+ Hits 2595 2604 +9
- Misses 1256 1261 +5
- Partials 498 499 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice. I haven't tested it, but the unit tests look convincing. I left a few comments about the empty-string to "n/a" feature.
I found a better solution for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, this looks all good! Thanks. I think I'd now also like to add a feature in list
to skip empty columns.
I started to think about #298 and realized
rectify
doesn't touch .janno files at all so far. So I thought I first add a simpler .janno-editing feature: Removing empty columns. That is also a pretty common task. Maybe one dayrectify
will rather bemodify
🤔