Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to GHC 9.6.6 and a new resolver #328

Merged
merged 10 commits into from
Jan 16, 2025
Merged

Switch to GHC 9.6.6 and a new resolver #328

merged 10 commits into from
Jan 16, 2025

Conversation

nevrome
Copy link
Member

@nevrome nevrome commented Jan 14, 2025

No description provided.

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 59.71%. Comparing base (eb024c7) to head (bc6ff13).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
src/Poseidon/CLI/Serve.hs 41.66% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #328      +/-   ##
==========================================
+ Coverage   59.67%   59.71%   +0.04%     
==========================================
  Files          29       29              
  Lines        4364     4364              
  Branches      499      497       -2     
==========================================
+ Hits         2604     2606       +2     
  Misses       1261     1261              
+ Partials      499      497       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nevrome nevrome marked this pull request as ready for review January 14, 2025 16:00
@nevrome nevrome requested a review from stschiff January 14, 2025 16:00
Copy link
Member

@stschiff stschiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks. I've looked at the code changes, and I've just tested it on my Mac with the new GHC, including pedantic tests. Looks all good to me.

@nevrome nevrome merged commit e284883 into master Jan 16, 2025
3 of 4 checks passed
@nevrome nevrome deleted the ghc966 branch January 16, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants