Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor #1

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

refactor #1

wants to merge 8 commits into from

Conversation

MayaGans
Copy link
Collaborator

An idea for a refactor, we can leave this as a PR or just a branch in the repo :)

Also - the footer argument isn't working and I'm not sure why?

image

@DivadNojnarg
Copy link
Collaborator

Thanks @MayaGans. The footer isn't that important. Actually, I'll ask people to drop the tablerDash template and start with only bslib elements. The fresh-start branch contains a completly cleaned up UI with only instructions in the code to get started with the new design.

@DivadNojnarg
Copy link
Collaborator

Few comments on your version:

  • Maybe add a title in the header.
  • I would really put the select input centered and much bigger.
  • The types tags are too large. I would also likely use some shades: light grey -> 0.5, dark grey -> x2 and no damages: close to white? If we want to avoid using colors.
  • We might also want to change the graph colors: main pokemon line color would be dark grey (the default color) and the previous evolution stage would be light grey.
  • The only color I would use is for the type to better differentiate them as well as the location type (forest, caves, ....). There is a function that return the type color mapping in the code.

I can take care of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants