Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log a warning on parse errors, but don't return an LSP error #120

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

DavisVaughan
Copy link
Collaborator

@DavisVaughan DavisVaughan commented Dec 20, 2024

Closes #65

Merge after #122

@DavisVaughan DavisVaughan requested a review from lionel- January 6, 2025 18:08
@DavisVaughan DavisVaughan force-pushed the feature/no-toast-on-parse-error branch from bea3663 to d9fcebf Compare January 8, 2025 18:32
@DavisVaughan DavisVaughan merged commit f7ac7e4 into main Jan 8, 2025
4 checks passed
@DavisVaughan DavisVaughan deleted the feature/no-toast-on-parse-error branch January 8, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parse errors probably shouldn't trigger toast notifs during document formatting
2 participants