Send structured InitializationOptions to the server
#121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, this lets us respect `air.logLevel` and `air.dependencyLogLevels` on server startup User and workspace level settings are not used yet but are included for completeness
This comment was marked as outdated.
This comment was marked as outdated.
lionel-
reviewed
Jan 7, 2025
| "properties": { | ||
| "air.logLevel": { | ||
| "default": null, | ||
| "markdownDescription": "Controls the log level of the language server.\n\n**This setting requires a restart to take effect.**", |
There was a problem hiding this comment.
These static settings are a bit annoying. Probably worth it to make it dynamic right away?
There was a problem hiding this comment.
Going to do in a follow up after we rework testing a bit to allow for dynamicness in the logging code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #100
This PR sends a minimal amount of initialization options through
initializationOptions-logLevelanddependencyLogLevels. These are currently our only 2 client side options, but the important part is that they really are initialization time options.For 99% of client side options, this isn't really the right thing to do. We are instead supposed to "pull" options dynamically on the server side. We would do that at startup and after any meaningful change notification (workspace changes, configuration changes, etc). See microsoft/language-server-protocol#567 for a big discussion about this. Note that I don't think ruff really does this correctly.
If we ever wanted
logLevelto be dynamic, it would come throughinitializationOptionsAND also be "pull"ed dynamically (as a way to refresh it).Here are the places we might dynamically "pull" options in the future (once we have user/workspace level options)
-
Initializednotification handler, where we'd request them for the first time (possibly also adding a lock to prevent any other requests from running until we've requested them and set them)-
DidChangeWorkspaceFolders, requesting them for opened workspaces, purging them for closed workspaces-
DidChangeConfiguration, where we useDidChangeConfigurationas a simple notification that "something" has changed in configuration, so we have to repull every scope we are interested in (this is now how you are supposed to useDidChangeConfigurationapparently)