Fix r_task::initialize() timing issue
#566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And document some things that rely on it
That's a good reason to switch to an independent binary in integration tests, so we don't hit any testing path at all: #562. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both
modules::initialize()andresource_loaded_namespaces()callr_task::spawn_idle(). Even though that is async, it blocks until the task channels are initialized, sor_task::initialize()has to run first!We didn't catch this during testing because
r_task::spawn_idle()has that escape hatch during testing and just runs immediately. But CI in Positron caught an issue, and it was easy to reproduce by just starting up R with the latest version of ark in Positron. Things crashed immediately.