Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken output pane caused by lines with hashtags only #590

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Fix broken output pane caused by lines with hashtags only #590

merged 3 commits into from
Oct 17, 2024

Conversation

kv9898
Copy link
Contributor

@kv9898 kv9898 commented Oct 16, 2024 •
edited by lionel-
Loading

@kv9898 kv9898 marked this pull request as ready for review October 16, 2024 00:02
lionel-
lionel- reviewed Oct 16, 2024
View reviewed changes
Copy link
Contributor

@lionel- lionel- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you add the relevant unit tests please?

@kv9898
Copy link
Contributor Author

kv9898 commented Oct 16, 2024

Thanks! Could you add the relevant unit tests please?

Yes! Thanks to the example tests you created, I added 2 lines to your functions.

@kv9898
Copy link
Contributor Author

kv9898 commented Oct 17, 2024

@lionel- I made another PR at #593, which supports the nested outline feature and also fixes this very issue, but much more changes are involved. On the other hand, this PR is a quick fix and can be merged/reviewed easily.

@lionel-
Copy link
Contributor

lionel- commented Oct 17, 2024

wow that's great, thanks so much!

@lionel- lionel- merged commit 33100a0 into posit-dev:main Oct 17, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lionel- lionel- lionel- left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kv9898 @lionel-