Add saving plot as tiff #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavisVaughan
approved these changes
Oct 22, 2024
Comment on lines
+469
to
+473
| /// This event is used to signal that the stored messages the front-end | ||
| /// replays when constructing multi-output plots should be reset. This | ||
| /// happens for things like a holoviews extension being changed. | ||
| #[serde(rename = "clear_webview_preloads")] | ||
| ClearWebviewPreloads, |
There was a problem hiding this comment.
Is there some reason this is getting added in now alongside this?
There was a problem hiding this comment.
Maybe this was from a previous update to the comm definition used to generate code, and it showed up now?
https://github.com/posit-dev/positron/blame/a0e53f8b220ebdcc815cf144ea141313954924d9/positron/comms/ui-frontend-openrpc.json#L450
There was a problem hiding this comment.
Yes, this came up after regenerating so I think it needed an update.
lionel-
approved these changes
Oct 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address posit-dev/positron#4690
PR for plot comm update: posit-dev/positron#5044
Regenerate the comms and add TIFF saving support.