Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved matrix representation in variables pane #711

Merged
merged 2 commits into from
Feb 20, 2025
Merged

Conversation

dfalbel
Copy link
Contributor

@dfalbel dfalbel commented Feb 13, 2025

I agree with @EmilHvitfeldt in posit-dev/positron#3656 that diisplaying the number of rows and columns is more useful as displaying the actual values for matrices in the variables pane. One can still see the values by inspecting/ or opening in the data explorer.

Adresses posit-dev/positron#3656

@dfalbel dfalbel requested a review from lionel- February 13, 2025 15:21
Copy link
Contributor

@lionel- lionel- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a test to check for consistency of matrix and df methods so that if we change the display in one place we don't forget to update the other?

@dfalbel
Copy link
Contributor Author

dfalbel commented Feb 19, 2025

Good idea, added it in 54ef6db

@dfalbel dfalbel requested a review from lionel- February 19, 2025 14:27
@dfalbel dfalbel merged commit 3dddbb9 into main Feb 20, 2025
5 of 6 checks passed
@dfalbel dfalbel deleted the improve/matrix-view branch February 20, 2025 13:16
@github-actions github-actions bot locked and limited conversation to collaborators Feb 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants