-
Notifications
You must be signed in to change notification settings - Fork 79
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Move connections pane into core positron (#4967)
Addresses #4874 Needs codicons from: posit-dev/positron-codicons#6 Needs ark side: posit-dev/ark#589 This PR is an initial implementation of the connections pane into Positron core. It's still missing a lot of functionality, but will eventually be equivalent to the current positron-connections extension. TODO: - [x] Workspace storage of previous connections - [x] Setting to opt-in for the new implementation - [x] Button to open data explorer for a `Table` or `View` - [x] Codicons for most common DB data types (schema, collections, etc) and for creating a new connection - [x] Review event listeners disposing - [x] Implement Python side of new GetMetadata RPC - [x] Implement refresh connections - [x] Display the field type - [x] Display the language for each connection - [x] Review error handling - [x] Fix smoke tests (smoke tests are passing locally) - [x] Fix integration tests - [x] Rename 'Connections Core' to just 'Connections' - [x] Support for the focus event Demo: https://github.com/user-attachments/assets/9e7b7905-3c1b-421d-a9e4-6c8e5d3b3b94 Must be enabled with: ![image](https://github.com/user-attachments/assets/b3870a00-9fe2-4144-b54e-d74b7521945f)
- Loading branch information
Showing
26 changed files
with
2,313 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.