-
Notifications
You must be signed in to change notification settings - Fork 78
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Data Explorer: Implement row filters and column sorting for duckdb ba…
…ckend (#5168) Addresses #5126 and #5127. It provides the full set of row filter types and column sorting. A lot of the work was in writing the unit tests code (with `yarn test-extension -l positron-duckdb`) to verify correctness, but I was fairly thorough and turned up some bugs while writing the unit tests. DuckDB does not provide stable sorting (i.e. rows may be permuted if the sort keys are equal) so I had to introduce an auxiliary "row_index" field to do an order-preserving sort to make it easier to unit test.
- Loading branch information
Showing
3 changed files
with
593 additions
and
152 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.