Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add /opt/python to environment search directories #6261

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

sharon-wang
Copy link
Member

Summary

Release Notes

New Features

Bug Fixes

  • N/A

QA Notes

See #6254 for notes. /opt/python installations of Python should now be picked up by Positron without adding /opt/python to the PATH on UNIX-alike machines.

Copy link

E2E Tests 🚀
This PR will run tests tagged with: @:critical

readme  valid tags

Copy link
Contributor

@isabelizimm isabelizimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Future art: I just dropped a pyenv env into /opt/python, and it is registering as Unknown. At some point (or maybe just Workbench specific?), it might be nice to give a better name if we can.

Screenshot 2025-02-10 at 1 18 28 PM

@sharon-wang
Copy link
Member Author

Future art: I just dropped a pyenv env into /opt/python, and it is registering as Unknown. At some point (or maybe just Workbench specific?), it might be nice to give a better name if we can.

Yes thanks for calling this out! We have been seeing this with interpreters manually added to the PATH as well. I've opened #6270 to capture this!

@sharon-wang sharon-wang merged commit 750ed9f into main Feb 10, 2025
28 checks passed
@sharon-wang sharon-wang deleted the include-opt-python-in-disco branch February 10, 2025 19:42
@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants