Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode-python upstream changes v2024.20.0 to v2025.0.0 #6298

Merged
merged 7 commits into from
Feb 13, 2025

Conversation

isabelizimm
Copy link
Contributor

@isabelizimm isabelizimm commented Feb 11, 2025

Includes changes from: v2024.22.1, v2024.22.2, and v2025.0.0.

A lot of restructuring tests and removing now-unused code, especially for tensorboard.

Release Notes

New Features

  • N/A

Bug Fixes

  • N/A

QA Notes

should pass all ci, lsp tasks should still work, etc

Copy link

github-actions bot commented Feb 11, 2025

E2E Tests 🚀
This PR will run tests tagged with: @:critical

readme  valid tags

@@ -7,6 +7,7 @@ import { traceError } from '../../../../logging';

export enum NativePythonEnvironmentKind {
Conda = 'Conda',
Pixi = 'Pixi',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pixi support for PET now! 🚀

@isabelizimm
Copy link
Contributor Author

isabelizimm commented Feb 12, 2025

I still need to update the Python dependencies, but the rest is ready to go to take for a spin!

General question: @austin3dickey had suggested adding a tag to upstream merge PRs so we can quickly find all of them. What do people think of using the upstream tag? It looks like the intended use was for issues that should be solved upstream, but I do quite like name 😅

seeM
seeM previously approved these changes Feb 13, 2025
Copy link
Contributor

@seeM seeM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! And everything seems to work well locally. Just need to make sure CI passes then good to merge.

Looks like they've switched over permanently to the newer test adapter, so we get colorized pytest output (and probably a lot more):

image

It also looks like they've done some work related to the Python Environments extension but I'm not sure how to try it out in Positron. I don't think the extension is available on Open VSX.

@isabelizimm isabelizimm marked this pull request as ready for review February 13, 2025 18:07
@isabelizimm isabelizimm merged commit 8309e30 into main Feb 13, 2025
28 checks passed
@isabelizimm isabelizimm deleted the vscode-python-v2025.0 branch February 13, 2025 18:51
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants