Fix Variables for python types with unexpected __qualname__ behavior #6364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses issue #6237 dfply.base.Intention has a bad implementation of __getattr__ which impacts calls to built-in attributes such as __qualname__. Instead of returning a str it incorrectly returns a new instance of Intention(). This breaks our inspection logic and stopped Variables from working once objects of this type were encountered. This change adds some simple defensive code to the utility used by our Inspectors that summarize variables. Added a simple unit test to cover this case.
|
E2E Tests 🚀 |
isabelizimm
reviewed
Feb 14, 2025
extensions/positron-python/python_files/posit/positron/utils.py
Outdated
Show resolved
Hide resolved
isabelizimm
previously approved these changes
Feb 14, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #6237
dfply.base.Intentionhas a bad implementation of__getattr__which impacts calls to built-in attributes such as__qualname__. Instead of returning astrit incorrectly returns a new instance ofIntention(). This breaks our inspection logic and stopped Variables from working once objects of this type were encountered.This change adds some simple defensive code to the utility used by our Inspectors that summarize variables.
Added a simple unit test to cover this case.
Release Notes
New Features
Bug Fixes
__qualname__return values do not stop Variables inspection. Fixes Variables pane does not refresh when variables are changed afterfrom dfply import *#6237.QA Notes
Added a unit test to cover the general problem, but this fix covers the specific type mentioned in the customer issue.