Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos in venv installation instructions in install.qmd #36

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Fix typos in venv installation instructions in install.qmd #36

merged 1 commit into from
Nov 30, 2023

Conversation

chris-park
Copy link
Contributor

Fix minor typos in venv installation instructions.

@chris-park
Update install.qmd
5e796c7 
Fix typos in venv installation instructions.
@wch
Copy link
Contributor

wch commented Nov 29, 2023

Hi, thanks for the PR. The use of venv instead of .venv was not a typo -- it was intentional. That said, it does look like the Python community does somewhat favor using .venv, so I think it's reasonable to take this change.

@chris-park
Copy link
Contributor Author

Hi Winston, thanks for your comment. It was mainly so that the code was consistent with the existing comment, which mentions .venv.

@wch
Copy link
Contributor

wch commented Nov 30, 2023

Oh, ha -- I guess that one or the other was a typo.

@wch wch merged commit bafecca into posit-dev:main Nov 30, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wch wch wch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chris-park @wch