Avoid LinkingTo dependencies in package resolution
#115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Packages listed under LinkingTo are required for building dependent packages, but not at runtime as they are header-only or statically linked libraries. So, we can ignore these packages when we're looking for dependencies to bundle for webR. In webR 0.4.1, these packages will also be ignored when invoking `webr::install()`.
gadenbuie
approved these changes
Aug 2, 2024
georgestagg
force-pushed
the
no-linkingto
branch
from
15db8e6
to
cb37e79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages listed under
LinkingToare required for building dependent packages, but not loading them at runtime.So, we can ignore these R packages when we're looking for dependencies to bundle with a webR+shinylive app. In webR 0.4.1, these packages will also be ignored when invoking
webr::install(), and I'm told the nativeinstall.packages()already does the same.See quarto-ext/shinylive#59 for discussion.
c.f. r-wasm/webr#463