feat: Make "simple browser" an explicit preview type option #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
"simple browser"as ashiny.previewTypeoption and updates the help text to reference Positron.Technically, this just makes implicit behavior explicit -- any value that isn't
internal,external, ornonedefaults to using the Simple Browser, but you had to modify settings via JSON to take advantage.I find it useful to differentiate between the viewer pane and a simple browser. For example, while working on a workshop I could use the Viewer pane to preview Quarto slides while also running and editing a Shiny app with its preview in a Simple Browser tab.
Note that we have to declare both values up-front. In VS Code extensions, it's not possible to dynamically set the allowed values of an enum configuration setting.