Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --version CLI flag #610

Merged
merged 3 commits into from
May 9, 2022
Merged

Add --version CLI flag #610

merged 3 commits into from
May 9, 2022

Conversation

pirate
Copy link
Contributor

@pirate pirate commented Apr 5, 2021

We use mercury-parser over at ArchiveBox, and one of the things AB expects of all its dependencies is the ability to get the version by calling command --version.

This PR just adds that ability to this project.

Copy link
Contributor

@johnholdun johnholdun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@johnholdun johnholdun merged commit 99062da into postlight:master May 9, 2022
@pirate pirate deleted the patch-1 branch May 10, 2022 04:45
@pirate
Copy link
Contributor Author

pirate commented Oct 20, 2023

Did this get reverted somehow? It seems as if the --version flag doesn't work on the latest postflight-parser 2.2.3

Nvm, I see what happened, the arg is missing from the bottom. Opened a new PR to fix it: #750

pirate added a commit to pirate/mercury-parser that referenced this pull request Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants