feat: add new secret variable type #1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theonly1me
reviewed
Nov 30, 2023
| SAFE_CONTEXT_VARIABLES = ['_variables', 'environment', 'globals', 'collectionVariables', 'cookies', 'data', | ||
| 'request', 'response'], | ||
| SAFE_CONTEXT_VARIABLES = | ||
| ['_variables', 'environment', 'globals', 'secrets', 'collectionVariables', 'cookies', 'data', |
There was a problem hiding this comment.
@Pranav2612000 let's call them vaultVariables similar to collectionVariables. Calling them secrets adds ambiguity because of the secret type that exists. Also, everywhere else within these files.
Pranav2612000
force-pushed
the
feat/add-secret-variable-type
branch
from
da6b1fa to
b80150c
Compare
theonly1me
approved these changes
Dec 13, 2023
Pranav2612000
force-pushed
the
feat/add-secret-variable-type
branch
4 times, most recently
from
0b9ce8e to
30dc1e9
Compare
codenirvana
force-pushed
the
feat/add-secret-variable-type
branch
from
30dc1e9 to
6cdbc3b
Compare
Pranav2612000
force-pushed
the
feat/add-secret-variable-type
branch
3 times, most recently
from
0008aff to
84a34ec
Compare
Pranav2612000
force-pushed
the
feat/add-secret-variable-type
branch
from
84a34ec to
4273ebc
Compare
codenirvana
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.