Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Auth state management for ntlm auth in runner #1361

Closed
wants to merge 5 commits into from

Conversation

sandeep-singh-pstmn
Copy link
Contributor

@sandeep-singh-pstmn sandeep-singh-pstmn commented Dec 5, 2023

In this PR, we are storing the Auth state in a separate variable, which resets every time a new req item runs
after this chnage, we will not be able to access state data in the script, which makes sense as to why we need to expose internal state management in the script to store that in auth object

Screenshot 2023-12-05 at 10 19 30 AM

@sandeep-singh-pstmn sandeep-singh-pstmn marked this pull request as draft December 5, 2023 02:39
@sandeep-singh-pstmn sandeep-singh-pstmn marked this pull request as ready for review December 5, 2023 04:51
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2023

Codecov Report

Attention: Patch coverage is 95.65217% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 79.13%. Comparing base (3f98974) to head (851ffa0).

Files Patch % Lines
lib/authorizer/auth-interface.js 87.50% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1361      +/-   ##
===========================================
+ Coverage    79.09%   79.13%   +0.04%     
===========================================
  Files           45       45              
  Lines         3367     3379      +12     
  Branches       970      974       +4     
===========================================
+ Hits          2663     2674      +11     
- Misses         704      705       +1     
Flag Coverage Δ
integration 70.55% <86.95%> (+0.04%) ⬆️
legacy 45.90% <13.04%> (-0.14%) ⬇️
unit 41.87% <56.52%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@coditva coditva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: This has breaking changes:

  1. NTLM header and state will not be available in auth object (in pre-request script).
  2. NTLM header cannot be set via the pre-request script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants