-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix - Auth state management for ntlm auth in runner #1361
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1361 +/- ##
===========================================
+ Coverage 79.09% 79.13% +0.04%
===========================================
Files 45 45
Lines 3367 3379 +12
Branches 970 974 +4
===========================================
+ Hits 2663 2674 +11
- Misses 704 705 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: This has breaking changes:
- NTLM header and state will not be available in
auth
object (in pre-request script). - NTLM header cannot be set via the pre-request script.
In this PR, we are storing the Auth state in a separate variable, which resets every time a new req item runs
after this chnage, we will not be able to access state data in the script, which makes sense as to why we need to expose internal state management in the script to store that in auth object