Fix the issue of sandbox context not getting garbage collected #1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vedkribhu
force-pushed
the
fix/memory-leak
branch
from
7c0c1a1 to
31ba36d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1373 +/- ##
===========================================
+ Coverage 79.05% 79.07% +0.01%
===========================================
Files 45 45
Lines 3357 3360 +3
Branches 964 964
===========================================
+ Hits 2654 2657 +3
Misses 703 703
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vedkribhu
force-pushed
the
fix/memory-leak
branch
2 times, most recently
from
bc744ab to
e1c8aa3
Compare
- execution.result and execution.skipRequest listeners
were not getting garbage collected
vedkribhu
force-pushed
the
fix/memory-leak
branch
from
e1c8aa3 to
d54d2ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The memory leak surfaced as a result of changes introduced in the following pull request: https://github.com/postmanlabs/postman-runtime/pull/1354/files. Two specific issues led to the memory leak:
context.onresulted in the inability of the garbage collector to handle all handlers attached throughcontext.on.