Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated async access to vault secrets #1452

Merged
merged 6 commits into from
Sep 4, 2024

Conversation

appurva21
Copy link
Member

@appurva21 appurva21 commented Sep 2, 2024

Changes

  • Integrated event-based interface to allow set, get and unset operations on vault variables
  • Stop sending complete vault secrets to the sandbox
  • Throw access denied error when pm.vault is not accessible in scripts

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.63%. Comparing base (7c6debc) to head (43270c0).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
lib/runner/extensions/event.command.js 87.50% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1452      +/-   ##
===========================================
+ Coverage    73.59%   73.63%   +0.04%     
===========================================
  Files           45       45              
  Lines         3401     3414      +13     
  Branches       985      986       +1     
===========================================
+ Hits          2503     2514      +11     
- Misses         700      701       +1     
- Partials       198      199       +1     
Flag Coverage Δ
integration 63.70% <87.50%> (+0.07%) ⬆️
legacy 39.13% <31.25%> (-0.07%) ⬇️
unit 39.57% <6.25%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@appurva21 appurva21 force-pushed the feature/async-vault-access branch from 979c353 to 4074c17 Compare September 3, 2024 08:27
@appurva21 appurva21 force-pushed the feature/async-vault-access branch from b8f0486 to b8ed3d1 Compare September 4, 2024 11:11
@appurva21 appurva21 merged commit 7ddff0f into develop Sep 4, 2024
12 of 14 checks passed
@appurva21 appurva21 deleted the feature/async-vault-access branch September 4, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants