Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRUST-1439] Remove port from host when matching vault scope patterns #1468

Conversation

saksham-postman
Copy link
Collaborator

Changes

This PR modifies the vault scope matching logic to ignore the port number when comparing against domain patterns. This change ensures that variables are correctly filtered regardless of whether a port is specified in the URL.

Implementation

  • In lib/runner/util.js, we now strip the port from the URL before testing it against domain patterns.
  • This is achieved by using a regex to remove any port number (:digits) from the URL string.

Motivation

This change addresses an issue where vault scopes were not being correctly applied when the URL included a port number, potentially leading to incorrect variable filtering.

Testing

  • Verify that vault scopes are correctly applied for URLs both with and without port numbers.
  • Ensure existing functionality remains intact for URLs without ports.

Related

Ticket: TRUST-1439

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant