[TRUST-1439] Remove port from host when matching vault scope patterns #1468
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR modifies the vault scope matching logic to ignore the port number when comparing against domain patterns. This change ensures that variables are correctly filtered regardless of whether a port is specified in the URL.
Implementation
lib/runner/util.js
, we now strip the port from the URL before testing it against domain patterns.:digits
) from the URL string.Motivation
This change addresses an issue where vault scopes were not being correctly applied when the URL included a port number, potentially leading to incorrect variable filtering.
Testing
Related
Ticket: TRUST-1439