Support sums in div witgen #2464
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schaeff
commented
Feb 7, 2025
| Some( | ||
| let quotient_value = dividend.to_arbitrary_integer() / divisor.to_arbitrary_integer(); | ||
| println!("Quotient: {quotient_value}"); | ||
| let limb_size_bits = limb_size_bits.ok_or("No limb size")?; |
There was a problem hiding this comment.
The original case where there's a single limb is not implemented yet
|
Closing for now as we can instead amend the div test in #2425 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Division witgen expects a pattern like
dividend = divisor * quotient + remainder(where the two terms on the rhs can also be swapped).This works when
quotientandremainderare witness columns, but fails when they are intermediate columns.Extend division witgen to support a pattern of the form:
This enables in particular solving: