Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor disaster recovery location data source and documentation #28

Closed
wants to merge 6 commits into from
Closed

Refactor disaster recovery location data source and documentation #28

wants to merge 6 commits into from

Conversation

Diptipowervs
Copy link

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@Diptipowervs Diptipowervs changed the title Catalog refactor disaster recovery location data source and documentation Refactor disaster recovery location data source and documentation Dec 31, 2023
ismirlia
ismirlia previously approved these changes Jan 3, 2024
View reviewed changes
Copy link
Collaborator

@ismirlia ismirlia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, wait for Michael's approval before opening PR in main terraform provider repo.

ismirlia
ismirlia previously approved these changes Jan 10, 2024
View reviewed changes
michaelkad
michaelkad requested changes Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@michaelkad michaelkad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think keeping this to Boolean since that is how it is done in the IBM

@Diptipowervs @michaelkad
Apply suggestions from code review
2ff21d4 
Add Boolean in place of bool

Co-authored-by: michaelkad <[email protected]>
@Diptipowervs
Copy link
Author

I think keeping this to Boolean since that is how it is done in the IBM

Changes made

@Diptipowervs
Copy link
Author

PR opened in main repo

@michaelkad michaelkad deleted the disaster-recovery-refactor branch May 28, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelkad michaelkad michaelkad requested changes

@ismirlia ismirlia ismirlia left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Diptipowervs @michaelkad @ismirlia