Make repository tests independant + liquibase log level = ERROR and hikari log level = INFO #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Etienne Homer <[email protected]>
Signed-off-by: Etienne Homer <[email protected]>
Signed-off-by: Etienne Homer <[email protected]>
Signed-off-by: Etienne Homer <[email protected]>
etiennehomer
changed the title
EtienneLt
approved these changes
Jan 24, 2025
Signed-off-by: Etienne Homer <[email protected]>
antoinebhs
approved these changes
Jan 29, 2025
|
Maybe check the time taken by the tests with and without dirtying: is it the best strategy? |
It makes tests longer on NetworkStoreRepositoryTest : 1sec => 11sec. But it's not so long compared to the ~5 min of the tests execution. |
Signed-off-by: Etienne Homer <[email protected]>
Signed-off-by: Etienne Homer <[email protected]>
Signed-off-by: Etienne Homer <[email protected]>
Signed-off-by: Etienne Homer <[email protected]>
|
jonenst
approved these changes
Jan 29, 2025
etiennehomer
changed the title
EtienneLt
pushed a commit
that referenced
this pull request
Feb 4, 2025
Using a different db for each method with the cheap technique like other places. Reduce logging verbosity by not logging liquibase updates at all, they are too noisy at the begining of each test Signed-off-by: Etienne Homer <[email protected]>
EtienneLt
pushed a commit
that referenced
this pull request
Feb 4, 2025
Using a different db for each method with the cheap technique like other places. Reduce logging verbosity by not logging liquibase updates at all, they are too noisy at the begining of each test Signed-off-by: Etienne Homer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.