Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt iidm importer to extended version of AMPL exporter #81

Merged
merged 4 commits into from
Nov 19, 2024

Conversation

p-arvy
Copy link
Member

@p-arvy p-arvy commented Oct 1, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

The IIDM importer of the AMPL code is adapted to the extended version of the AMPL exporter (v1.1).

What is the current behavior?

The IIDM importer of the AMPL code is based on the basic AMPL exporter (v1).

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

@p-arvy p-arvy requested review from So-Fras and klorel October 1, 2024 16:09
open-reac/README.md Outdated Show resolved Hide resolved
Signed-off-by: p-arvy <[email protected]>
Copy link

sonarqubecloud bot commented Oct 2, 2024

Copy link
Member

@So-Fras So-Fras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the integration of the new exporter!

@So-Fras So-Fras merged commit e432731 into main Nov 19, 2024
6 checks passed
@So-Fras So-Fras deleted the adapt-iidm-importer-to-new-ampl-exporter branch November 19, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants