Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynawo simulation nordic case notebook #31

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Lisrte
Copy link

@Lisrte Lisrte commented Dec 18, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Feature

What is the current behavior?

What is the new behavior (if this is a feature change)?
Add a notebook for Dynawo dynamic simulation nordic case

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

Signed-off-by: lisrte <[email protected]>
Use network variant
Display TCB simulation curve

Signed-off-by: lisrte <[email protected]>
@Lisrte Lisrte self-assigned this Dec 18, 2024
@Lisrte Lisrte changed the title Dynawo simulation nordic case Dynawo simulation nordic case notebook Dec 18, 2024
@Lisrte Lisrte requested a review from flo-dup February 10, 2025 13:21
dynawo/nordic case/pypowsybl_dynawo.ipynb Outdated Show resolved Hide resolved
dynawo/nordic case/pypowsybl_dynawo.ipynb Outdated Show resolved Hide resolved
dynawo/nordic case/pypowsybl_dynawo.ipynb Outdated Show resolved Hide resolved
dynawo/nordic case/pypowsybl_dynawo.ipynb Outdated Show resolved Hide resolved
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't get the simulation to run with those parameters (I changed the homeDir to the installation directory). Maybe the problem is in the config? Or on my side...

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the problem was, the config changes need a kernel restart to be taken into account... 😒

dynawo/nordic case/pypowsybl_dynawo.ipynb Show resolved Hide resolved
@flo-dup
Copy link

flo-dup commented Feb 11, 2025

Thanks a lot @joyelfeghali for the comments in the notebook! 🙏
Just one thing, isn't there a mistake on your description of the first curve? The events you mentioned at 30s and 35s don't correspond to the curve, it seems. And similarly when you say "0.1s later", it's not 100% clear to me where on the curve we are (0.1s after which event?)

@joyelfeghali
Copy link
Collaborator

Thanks a lot @joyelfeghali for the comments in the notebook! 🙏 Just one thing, isn't there a mistake on your description of the first curve? The events you mentioned at 30s and 35s don't correspond to the curve, it seems. And similarly when you say "0.1s later", it's not 100% clear to me where on the curve we are (0.1s after which event?)

It's at 1.1s, after 0.1s after the fault occurred. I will correct it since it is not very clear.
For the other events, it is not very visible at the curve but at 34s to be precise the LTC starts changing taps but before that, it seems that we arrived at a kind of equilibrium, where the rate of change of the voltage is very slow. I will also change the way I describe it.

@joyelfeghali
Copy link
Collaborator

Thanks a lot @joyelfeghali for the comments in the notebook! 🙏 Just one thing, isn't there a mistake on your description of the first curve? The events you mentioned at 30s and 35s don't correspond to the curve, it seems. And similarly when you say "0.1s later", it's not 100% clear to me where on the curve we are (0.1s after which event?)

It's at 1.1s, after 0.1s after the fault occurred. I will correct it since it is not very clear. For the other events, it is not very visible at the curve but at 34s to be precise the LTC starts changing taps but before that, it seems that we arrived at a kind of equilibrium, where the rate of change of the voltage is very slow. I will also change the way I describe it.

Also maybe we could plot the curves in seconds, not ms?

@flo-dup
Copy link

flo-dup commented Feb 11, 2025

Also maybe we could plot the curves in seconds, not ms?

Could you do this @Lisrte?

joyelfeghali and others added 2 commits February 11, 2025 13:37
Replace automaton with automation system

Signed-off-by: lisrte <[email protected]>
@Lisrte
Copy link
Author

Lisrte commented Feb 11, 2025

Also maybe we could plot the curves in seconds, not ms?

Could you do this @Lisrte?

All done, I also changed the axis label a little.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants