-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Docker CI #517
base: master
Are you sure you want to change the base?
Enable Docker CI #517
Conversation
Hi @AshwinHIBM. Thanks for your PR. I'm waiting for a ppc64le-cloud member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
reporter_config: | ||
slack: | ||
channel: 'prow-job-notifications' | ||
report_template: 'Job {{.Spec.Job}} of type {{.Spec.Type}} ended with state {{.Status.State}}. <!subteam^S02N6DWBX0F> <{{.Status.URL}}|View logs>' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if the slack_reporter_config for these jobs can be defined in a common location, such as presets or slack_reporter_configs. Could you please take a look if you have some bandwidth?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One approach to address this by moving reporter_config
to config.yaml
doesn't work.
/ok-to-test |
6c2c9b3
to
02afba6
Compare
@Rajalakshmi-Girish has some good comments/requests so I'll approve if she does. Thanks Raji! |
02afba6
to
af3b2ad
Compare
799ef37
to
53c327e
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AshwinHIBM The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8710e91
to
0e8af61
Compare
23a11d9
to
fb05c55
Compare
@AshwinHIBM: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
fb05c55
to
b4056e0
Compare
b4056e0
to
114c053
Compare
The purpose of each job: