Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Docker CI #517

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AshwinHIBM
Copy link
Contributor

@AshwinHIBM AshwinHIBM commented Dec 10, 2024

The purpose of each job:

  1. periodic-config-docker: Check the configuration of the kernel for suitability to run Docker.
  2. periodic-build-dev-image-docker: Build a minimal Docker development image.
  3. postsubmit-unit-test-docker: Run unit tests against https://github.com/moby/moby
  4. postsubmit-integration-test-docker: Run integration tests against https://github.com/moby/moby
  5. postsubmit-integration-cli-docker: Run the end-to-end test suite from https://github.com/docker/cli

@ppc64le-cloud-bot ppc64le-cloud-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 10, 2024
@ppc64le-cloud-bot
Copy link
Contributor

Hi @AshwinHIBM. Thanks for your PR.

I'm waiting for a ppc64le-cloud member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ppc64le-cloud-bot ppc64le-cloud-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 10, 2024
config/jobs/periodic/docker/periodic-ci-docker.yaml Outdated Show resolved Hide resolved
config/jobs/periodic/docker/periodic-ci-docker.yaml Outdated Show resolved Hide resolved
reporter_config:
slack:
channel: 'prow-job-notifications'
report_template: 'Job {{.Spec.Job}} of type {{.Spec.Type}} ended with state {{.Status.State}}. <!subteam^S02N6DWBX0F> <{{.Status.URL}}|View logs>'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if the slack_reporter_config for these jobs can be defined in a common location, such as presets or slack_reporter_configs. Could you please take a look if you have some bandwidth?

Copy link
Contributor Author

@AshwinHIBM AshwinHIBM Feb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One approach to address this by moving reporter_config to config.yaml
doesn't work.

config/jobs/periodic/docker/periodic-ci-docker.yaml Outdated Show resolved Hide resolved
config/jobs/periodic/docker/periodic-ci-docker.yaml Outdated Show resolved Hide resolved
@Rajalakshmi-Girish
Copy link
Collaborator

/ok-to-test

@Rajalakshmi-Girish Rajalakshmi-Girish added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Dec 11, 2024
@ppc64le-cloud-bot ppc64le-cloud-bot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 16, 2024
@clnperez
Copy link

clnperez commented Jan 3, 2025

@Rajalakshmi-Girish has some good comments/requests so I'll approve if she does. Thanks Raji!

@AshwinHIBM AshwinHIBM force-pushed the enable-docker-ci branch 2 times, most recently from 799ef37 to 53c327e Compare January 23, 2025 11:37
@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AshwinHIBM
Once this PR has been reviewed and has the lgtm label, please assign rajalakshmi-girish for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@AshwinHIBM AshwinHIBM force-pushed the enable-docker-ci branch 2 times, most recently from 23a11d9 to fb05c55 Compare February 4, 2025 10:35
@ppc64le-cloud-bot
Copy link
Contributor

@AshwinHIBM: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-test-infra-prow-checkconfig fb05c55 link true /test pull-test-infra-prow-checkconfig

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@AshwinHIBM AshwinHIBM marked this pull request as draft February 4, 2025 10:36
@ppc64le-cloud-bot ppc64le-cloud-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants