pppd: Remove promptpass plugin #527
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is prompted by a number of factors: * The handling of privileges and possibly file descriptors is flawed * In many cases there will be no terminal accessible to the prompter program at the point where the prompter is run * The passwordfd plugin does much the same thing but does it more cleanly and securely. Signed-off-by: Paul Mackerras <[email protected]>
|
@paulusmack: You have canceled your PR? |
|
Yes, Jaco Kroon wanted me to be as vague as possible in the public commit, so I'll remove it along with other old stuff and not mention the bug in dropping privileges. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is prompted by a number of factors:
In many cases there will be no terminal accessible to the prompter program at the point where the prompter is run
The passwordfd plugin does much the same thing but does it more cleanly and securely.