Numba machine fix #149
Merged
Numba machine fix #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[skip actions]
Commented out `numba` import from the `__init__` for now, until the issues with crashing can be resolved. Moved `_IS_LOADING_DEFAULTS` out of the `updateMachine` function, declared the default value = False, and grabbed it via `utils.IS_LOADING_DEFAULTS`. (Note: It was already declared a `global` variable within the function, and I thought that would have been enough to avoid this error, but it works now) Lastly, altered the cleanup in the `_calc_path` function in `ops.py` - previously it was checking for and deleting objects without issues. In Blender 4.1 deleting an object would still leave behind mesh data that retained the object name, causing the cleanup function to not recognize and update old operations. Simply deleting the mesh data solves the issue, as it will also delete the object with it, even though the reverse is no longer true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commented out
numbaimport from the__init__for now, until the issues with crashing can be resolved.Moved
_IS_LOADING_DEFAULTSout of theupdateMachinefunction, declared the default= False, and grabbed it viautils.IS_LOADING_DEFAULTS.Note: It was already declared a
globalvariable within the function, and I thought that would have been enough to avoid this error, but it works nowLastly, altered the cleanup in the
_calc_pathfunction inops.py- previously it was checking for and deleting objects without issues.In Blender 4.0 and previous, deleting an object would also delete its associated mesh data.
In Blender 4.1 deleting an object would still leave behind mesh data that retained the object name, causing the cleanup function to not recognize and update old operations.
Simply deleting the mesh data solves the issue, as it will also delete the object with it, even though the reverse is no longer true.
Note: This may be a bug in 4.1, but the new method also works in 4.0, so I don't think it will need to change, even if Blender restores the previous behavior