Remove lazer score conversion to legacy score

The converter function stays because it's still used by transformer. Removal of the old transformer will be done later. Maybe.
ppy · Jan 30, 2024 · 2d19d39 · 2d19d39
1 parent 71619ce
commit 2d19d39
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 14 deletions.
diff --git a/app/Http/Controllers/Solo/ScoresController.php b/app/Http/Controllers/Solo/ScoresController.php
@@ -34,7 +34,6 @@ public function store($beatmapId, $tokenId)
             if ($scoreToken->score_id === null) {
                 $params = Score::extractParams($request->all(), $scoreToken);
                 $score = Score::createFromJsonOrExplode($params);
-                $score->createLegacyEntryOrExplode();
                 $scoreToken->fill(['score_id' => $score->getKey()])->saveOrExplode();
             } else {
                 // assume score exists and is valid

diff --git a/app/Models/Solo/Score.php b/app/Models/Solo/Score.php
@@ -223,15 +223,6 @@ public function assertCompleted(): void
         }
     }
 
-    public function createLegacyEntryOrExplode()
-    {
-        $score = $this->makeLegacyEntry();
-
-        $score->saveOrExplode();
-
-        return $score;
-    }
-
     public function getMode(): string
     {
         return Beatmap::modeStr($this->ruleset_id);

diff --git a/tests/Models/Solo/ScoreTest.php b/tests/Models/Solo/ScoreTest.php
@@ -53,7 +53,7 @@ public function testLegacyPassScoreRetainsRank()
         $this->assertTrue($score->passed);
         $this->assertSame($score->rank, 'S');
 
-        $legacy = $score->createLegacyEntryOrExplode();
+        $legacy = $score->makeLegacyEntry();
 
         $this->assertTrue($legacy->perfect);
         $this->assertSame($legacy->rank, 'S');
@@ -78,7 +78,7 @@ public function testLegacyFailScoreIsRankF()
         $this->assertFalse($score->passed);
         $this->assertSame($score->rank, 'F');
 
-        $legacy = $score->createLegacyEntryOrExplode();
+        $legacy = $score->makeLegacyEntry();
 
         $this->assertFalse($legacy->perfect);
         $this->assertSame($legacy->rank, 'F');
@@ -98,7 +98,7 @@ public function testLegacyScoreHitCounts()
             'statistics' => ['great' => 10, 'ok' => 20, 'meh' => 30, 'miss' => 40],
             'total_score' => 1000,
             'user_id' => 1,
-        ])->createLegacyEntryOrExplode();
+        ])->makeLegacyEntry();
 
         $this->assertFalse($legacy->perfect);
         $this->assertSame($legacy->count300, 10);
@@ -121,7 +121,7 @@ public function testLegacyScoreHitCountsFromStudlyCaseStatistics()
             'statistics' => ['Great' => 10, 'Ok' => 20, 'Meh' => 30, 'Miss' => 40],
             'total_score' => 1000,
             'user_id' => 1,
-        ])->createLegacyEntryOrExplode();
+        ])->makeLegacyEntry();
 
         $this->assertFalse($legacy->perfect);
         $this->assertSame($legacy->count300, 10);