Merge pull request #11141 from nanaya/passed-preserve

Mark score not ranked if not passed
ppy · Apr 3, 2024 · 9d9ec97 · 9d9ec97
2 parents 8268b7d + eeffcd8
commit 9d9ec97
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/app/Models/Solo/Score.php b/app/Models/Solo/Score.php
@@ -118,11 +118,12 @@ public static function extractParams(array $rawParams, ScoreToken|MultiplayerSco
         $params['started_at'] = $scoreToken->created_at;
         $params['user_id'] = $scoreToken->user_id;
 
+        $params['passed'] ??= false;
+        $params['preserve'] = $params['passed'];
+
         $beatmap = $scoreToken->beatmap;
         // anything that have leaderboard
-        $params['ranked'] = $beatmap !== null && $beatmap->approved > 0;
-
-        $params['preserve'] = $params['passed'] ?? false;
+        $params['ranked'] = $params['passed'] && $beatmap !== null && $beatmap->approved > 0;
 
         return $params;
     }