Always preserve multiplayer scores regardless of pass/fail #11118
Conversation
app/Models/Multiplayer/ScoreLink.php
Outdated
| // multiplayer scores are always preserved. | ||
| $score->preserve = true; | ||
| $score->saveOrExplode(); |
There was a problem hiding this comment.
This probably looks funny/awkward but there was an intention behind doing things that way. In most cases, scores are created by passing raw json params to Score::extractParams() and then passing that to Score::createFromJsonOrExplode(). But I didn't want to add a parameter to control preserve to extractParams() (which I would have had to do to avoid this silliness), because I don't want to allow an arbitrary api consumer to set preserve directly in the first place if that makes sense?
If I'm overthinking this do let me know and I'll shuffle across, but yeah that was the intention.
There was a problem hiding this comment.
seems fine but I think it can also be done with createFromJsonOrExplode([...$params, 'preserve' => true])
There was a problem hiding this comment.
Yeah that works, good call. Applied, thanks 👍
Related: ppy/osu-queue-score-statistics#141, #10946
We want to preserve failed scores if they come from multiplayer so that the results of the multiplayer room can be accessed in the indeterminate future. Currently this would not happen if a multiplayer score was a fail.