Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix profile page reorder not working without full reload #11747

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Fix profile page reorder not working without full reload #11747

merged 1 commit into from
Dec 17, 2024

Conversation

nanaya
Copy link
Collaborator

@nanaya nanaya commented Dec 16, 2024

Not quite sure what's happening here ಠ_ಠ

notbakaneko
notbakaneko approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@notbakaneko notbakaneko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how long this hasn't been working for, but it's because the elements are still on newBody instead of window.document so the extension isn't going to find them

@notbakaneko notbakaneko merged commit 1f46b13 into ppy:master Dec 17, 2024
3 checks passed
@nanaya
Copy link
Collaborator Author

nanaya commented Dec 17, 2024

I think all the selectors and stuff are based on the initial dom being passed, and all the elements did get the relevant ui- classes so it looks like to be something else...

@nanaya nanaya deleted the profile-sortable-delay branch December 17, 2024 13:09
@nanaya nanaya mentioned this pull request Jan 2, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notbakaneko notbakaneko notbakaneko approved these changes

Assignees
No one assigned
Labels
area:user-profile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nanaya @notbakaneko