Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't preload singletons #11791

Closed
wants to merge 1 commit into from
Closed

Don't preload singletons #11791

wants to merge 1 commit into from
+0 −2

Conversation

nanaya
Copy link
Collaborator

@nanaya nanaya commented Jan 14, 2025

Alternative fix for #11779. I think I put it there for benchmarking purpose but otherwise it's probably fine to init the singletons on first access.

@notbakaneko
Copy link
Collaborator

If they're not in warm they get constructed every request which defeats the purpose of the ones like Mods

@nanaya
Copy link
Collaborator Author

nanaya commented Jan 14, 2025

but then how did the LOCAL_CACHE_SINGLETONS survive 🤔

@nanaya
Copy link
Collaborator Author

nanaya commented Jan 14, 2025 •
edited
Loading

holy fuck that was some braindead logic there. nvm then

laravel/octane#265 (comment)

laravel/octane#265 (comment)

@nanaya nanaya closed this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area:tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nanaya @notbakaneko