Add seasonal leaderboards #11804
Open
Add seasonal leaderboards #11804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
@venix12 able to add some screenshots showing what we're adding here? 😄 |
updated the opening message accordingly 👁️ |
venix12
commented
Jan 28, 2025
| { | ||
| return cache_remember_mutexed( | ||
| "divisions:{$this->id}", | ||
| $GLOBALS['cfg']['osu']['seasons']['divisions_cache_duration'], |
There was a problem hiding this comment.
recently saw the duration being pulled from config/env in other places (tags) so just mimicked that, but wondering if this is actually needed here to begin with 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #11768.
Part of #8736.
This adds per-season rankings to current seasons page, including seasonal total score (as of #11768) and assigned division display (calculation of which is part of this PR).
image_urlcolumn ofdivisionstable isn't currently being utilized for purpose of the ranking display, but will be used for user profile division display in the future.