Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

put header-nav-v4 in front of blurred menu image #11817

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WebFreak001
Copy link

This adds a z-index: 1 to the dashboard friends watchlists account settings menu at the top on the start page, so it's in front of the blurred background image that is currently on top of the menu.

This makes the colors pop more as well as making the border color consistent on the active item as well as just the rest of the bar.

Before:

image

After:

image


Artificial purple image

The effect is most notable when the menu image has a lot of dark purple / areas of color close to the menu bar color (example using an image of just a solid purple block):

Before:

image

After:

image


Artificial white image

However it might not look as good with very light / white headers: (border color now matches the big blob though)

Before:

image

After:

image

ensures the colors pop more and avoids legibility issues with certainly colored menu images
@peppy
Copy link
Member

peppy commented Jan 27, 2025

I'm on board with this change visually 👍

@nanaya
Copy link
Collaborator

nanaya commented Jan 27, 2025

it's inconsistent with the the below the image though. If anything I'd rather just remove the extended highlight or reduce its size (or some other adjustments).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants