Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add defunct modding usergroups & pubble stubs #3173

Merged
merged 24 commits into from
Apr 14, 2020
Merged

Conversation

JBHyperion
Copy link
Contributor

Part of #3163 - Adds stub wiki articles for the MAT, BAT, MAT Leaders, BAT Managers and the proto-bubble icon

Looking for help with history of the BAT stub article in particular

@cl8n
Copy link
Member

cl8n commented Feb 5, 2020

some formatting things to keep in mind

  • metadata has to be surrounded by --- to do anything, for example
    ---
    tags:
      - MAT
    ---
    
    # Mapping Assistance Team
  • titles don't need linguistic articles("the"/"a"/"an") at the start, so here The Beatmap Appreciation Team should be Beatmap Appreciation Team
  • sections don't need to be qualified by the title again, here History of the BAT should be History
  • an article not clearly missing any info for what it's trying to be isn't a stub
  • first mentions of acronyms or alternate names should be italicised to show that you may refer to them again like that
  • should probably refer to acronyms in further usages instead of the full name (repeating something like "Quality Assurance Team" five times gets tiring to read)

wiki/Modding/BAT/en.md Outdated Show resolved Hide resolved
@JBHyperion
Copy link
Contributor Author

@cl8n Cleaned up everything from your review regarding style and metadata tagging. Regarding

an article not clearly missing any info for what it's trying to be isn't a stub

I can't guarantee these articles aren't missing information, since everything written here took place before I started modding and I can only go based on old hearsay and buried forum posts. If someone with better knowledge can confirm they contain everything they need to contain, then the stub tag can be removed.

@Loctav Loctav mentioned this pull request Feb 6, 2020
24 tasks
@MegaApplePi MegaApplePi self-assigned this Feb 6, 2020
@peppy
Copy link
Member

peppy commented Feb 6, 2020

pubble lives on!

@MegaApplePi MegaApplePi removed their assignment Feb 7, 2020
@MegaApplePi MegaApplePi self-assigned this Mar 14, 2020
wiki/Modding/BAT_Managers/en.md Outdated Show resolved Hide resolved
wiki/Modding/BAT_Managers/en.md Outdated Show resolved Hide resolved
Initially, one member of the BAT from each of the major geographical regions of The Americas ([Garven](https://osu.ppy.sh/users/244216)), Europe ([Kurai](https://osu.ppy.sh/users/77089)) and Asia ([NatsumeRin](https://osu.ppy.sh/users/151679)) was selected for this role.

<!-- TODO: QAT stub -->
These positions were later held by [Charles445](https://osu.ppy.sh/users/85000), [Loctav](https://osu.ppy.sh/users/71366) and [popner](https://osu.ppy.sh/users/759860) from the 22nd of December 2013 until the separation of the BAT into the Beatmap Nomination Group (later the [Beatmap Nominators](/wiki/People/The_Team/Beatmap_Nominators)) and the Quality Assurance Team on the 21st of August, 2014.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
These positions were later held by [Charles445](https://osu.ppy.sh/users/85000), [Loctav](https://osu.ppy.sh/users/71366) and [popner](https://osu.ppy.sh/users/759860) from the 22nd of December 2013 until the separation of the BAT into the Beatmap Nomination Group (later the [Beatmap Nominators](/wiki/People/The_Team/Beatmap_Nominators)) and the Quality Assurance Team on the 21st of August, 2014.
These positions were later held by [Charles445](https://osu.ppy.sh/users/85000), [Loctav](https://osu.ppy.sh/users/71366), and [popner](https://osu.ppy.sh/users/759860) on the 22nd of December 2013, until the BAT was separated into the Beatmap Nomination Group (later the [Beatmap Nominators](/wiki/People/The_Team/Beatmap_Nominators)) and the Quality Assurance Team on the 21st of August, 2014.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
These positions were later held by [Charles445](https://osu.ppy.sh/users/85000), [Loctav](https://osu.ppy.sh/users/71366) and [popner](https://osu.ppy.sh/users/759860) from the 22nd of December 2013 until the separation of the BAT into the Beatmap Nomination Group (later the [Beatmap Nominators](/wiki/People/The_Team/Beatmap_Nominators)) and the Quality Assurance Team on the 21st of August, 2014.
These positions were later held by [Charles445](https://osu.ppy.sh/users/85000), [Loctav](https://osu.ppy.sh/users/71366), and [popner](https://osu.ppy.sh/users/759860) on the 22nd of December 2013.
On the 21st of August, 2014, the BAT was separated into the Beatmap Nomination Group (later the [Beatmap Nominators](/wiki/People/The_Team/Beatmap_Nominators)) and the Quality Assurance Team.

I was thinking that this sentence was long, maybe it could be split up into two?

wiki/Modding/Beatmap_Appreciation_Team/en.md Show resolved Hide resolved
wiki/Modding/Beatmap_Appreciation_Team/en.md Outdated Show resolved Hide resolved
wiki/Modding/Beatmap_Appreciation_Team/en.md Outdated Show resolved Hide resolved
wiki/Modding/Beatmap_Appreciation_Team/en.md Outdated Show resolved Hide resolved
@cl8n cl8n self-requested a review March 18, 2020 05:19
wiki/Modding/MAT_Leaders/en.md Outdated Show resolved Hide resolved
@cl8n cl8n merged commit 1ae44b7 into ppy:master Apr 14, 2020
@JBHyperion JBHyperion deleted the Hyperionwiki branch July 13, 2020 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants