Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add input device stubs #3411

Merged
merged 6 commits into from
Dec 19, 2020
Merged

Add input device stubs #3411

merged 6 commits into from
Dec 19, 2020

Conversation

penguin2233
Copy link
Contributor

@penguin2233 penguin2233 commented Apr 5, 2020

party solves #3149

@cl8n
Copy link
Member

cl8n commented Apr 9, 2020

none of these add useful content, each needs at least a sentence or two about why/how they can be used to play osu

@penguin2233
Copy link
Contributor Author

unfortunately I do not know how you can use a Kinect or beatmania controller in osu so I can't add any information on that.

@penguin2233 penguin2233 marked this pull request as draft April 18, 2020 05:25
@peppy
Copy link
Member

peppy commented Apr 19, 2020

Please checkout the repo and use a local git client rather than making 10-20 commits for individual web edits.

@penguin2233
Copy link
Contributor Author

kinect support does not exist in osu. a workaround is to use a demo application which converts kinect movements to windows mouse movements but some say the kinect has a 300ms input lag which is not viable for osu play. not sure what to include in kinect article and if it should be made at all

@penguin2233 penguin2233 marked this pull request as ready for review June 30, 2020 01:11
Copy link
Contributor

@MilkyIQ MilkyIQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a bad pr; mainly just issues with grammar, formatting, and lack of information. Main conflicts are as follows:

  • I don't feel like the "Keyboard" and "Mouse" stubs are really needed. Sure, they are input devices, but it's something so integral to using a computer in general, that's it's not something specific enough to osu! to make it worth mentioning as its own stub. As such, I did not review them.
  • The stubs feel kinda empty. I think just adding images will do the trick. But meatier paragraphs and more links would help make this feel more concrete.
  • Articles need tags Tags would help make stubs appear more frequently in searches, which makes them more easily viewable.

wiki/Gameplay/Input_device/Bemani_controller/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Input_device/Bemani_controller/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Input_device/Bemani_controller/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Input_device/Dance_pad/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Input_device/Dance_pad/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Input_device/Touch_device/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Input_device/Wiimote/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Input_device/Wiimote/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Input_device/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Input_device/en.md Outdated Show resolved Hide resolved
@penguin2233 penguin2233 marked this pull request as draft July 4, 2020 02:04
Copy link
Contributor

@MilkyIQ MilkyIQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is alright atm. Just gotta make sure those paragraphs have empty lines in between them.

Do you have soft wrap enabled?

wiki/Gameplay/Input_device/Beatmania_controller/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Input_device/Beatmania_controller/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Input_device/Dance_pad/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Input_device/Drum_controller/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Input_device/Graphic_tablet/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Input_device/Graphic_tablet/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Input_device/Touch_device/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Input_device/Wiimote/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Input_device/Wiimote/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Input_device/en.md Outdated Show resolved Hide resolved
@penguin2233 penguin2233 marked this pull request as ready for review November 6, 2020 05:55
@TicClick TicClick added the state/needs rebase before merging, a maintainer will rebase to fix commit messages, etc. label Dec 8, 2020
@TicClick TicClick self-requested a review December 8, 2020 18:07
@TPGPL TPGPL changed the title input device stubs Add input device stubs Dec 19, 2020
@TPGPL TPGPL removed the state/needs rebase before merging, a maintainer will rebase to fix commit messages, etc. label Dec 19, 2020
TicClick
TicClick previously approved these changes Dec 19, 2020
@Joehuu Joehuu changed the title Add input device stubs Add input device stubs Dec 19, 2020
Co-authored-by: Joseph Madamba <[email protected]>
@TPGPL TPGPL dismissed stale reviews from TicClick via 0ce4fd0 December 19, 2020 02:28
@TicClick TicClick merged commit 8471d93 into ppy:master Dec 19, 2020
@penguin2233 penguin2233 deleted the stubs branch April 12, 2021 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants