-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add input device stubs #3411
Add input device stubs #3411
Conversation
none of these add useful content, each needs at least a sentence or two about why/how they can be used to play osu |
unfortunately I do not know how you can use a Kinect or beatmania controller in osu so I can't add any information on that. |
Please checkout the repo and use a local git client rather than making 10-20 commits for individual web edits. |
kinect support does not exist in osu. a workaround is to use a demo application which converts kinect movements to windows mouse movements but some say the kinect has a 300ms input lag which is not viable for osu play. not sure what to include in kinect article and if it should be made at all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a bad pr; mainly just issues with grammar, formatting, and lack of information. Main conflicts are as follows:
- I don't feel like the "Keyboard" and "Mouse" stubs are really needed. Sure, they are input devices, but it's something so integral to using a computer in general, that's it's not something specific enough to osu! to make it worth mentioning as its own stub. As such, I did not review them.
- The stubs feel kinda empty. I think just adding images will do the trick. But meatier paragraphs and more links would help make this feel more concrete.
- Articles need tags Tags would help make stubs appear more frequently in searches, which makes them more easily viewable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is alright atm. Just gotta make sure those paragraphs have empty lines in between them.
Do you have soft wrap enabled?
Co-authored-by: Joseph Madamba <[email protected]>
party solves #3149