Add ability to render frosted sliders #30347
Draft
+25
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppy
changed the title
|
Given that we've seen the blur shader cause performance issues on some devices in the past, doing this kind of effect on a gameplay element leaves me a touch cautious. It's a very cool effect, but we'd want to make sure that this is done with performance in mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC. I took peppy's tweet as a challenge to see if I can get this effect working in lazer. Since the "someone chooses to implement" part is done, I guess it is now time to figure out the "maybe" part.
Depends on ppy/osu-framework#6393
2024-10-19.02-06-11.mp4
This is primarily meant a proof of concept, so I only implemented this for legacy skins for now.
There is a lot of uncertainty about how this would actually work as part of the game, ux and stuff. Would it be a configurable property in skins? Perhaps a custom skin type?
Right now I'm doing the blurring at 50% resolution (and drawing the content on full resolution), though I've also tested it at 33% and 25% resolution and didn't notice any huge impact visually with either. I tried to dial in some values for the effect that look pretty good for most maps, but some more adjustments are definitely still needed.
Some screenshots