-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add remove buttons for mod entries in custom preset lists #30357
base: master
Are you sure you want to change the base?
Conversation
a.k.a. when no set is passed to the ModPresetRow class
This is not even negotiable. It needs to be localised. |
Before we go too far into bikeshedding here I kind of don't get why this feature exists.
|
I could say for sure that it's here for yielding to the current version of preset popup design, since I tried not to modify that if not necessary. My idea is that if the popup can be built into the preset list (or just add an entry to the context menu, as I've stated above), it should relieve the asymmetry problem. Or if possible, we can also add a popup just for adding mods, for summetry, but I think that's going too far.
This is not introduced, just presented. Removing a mod entry is considerably easier than adding and modifying one in current context, until we change that. |
You still haven't told me why the current methods of doing this (either remaking the preset, or clicking "Use current mods") are insufficient or inadequate. I'd like the answer to that before considering this feature on merit. |
From my perspective, I really hope that we can remake the preset UI first, which can help directly resolve the problems above. Then this PR can also be taken into account if possible. |
None of the problems you mention have anything to do with being able to delete a mod from the popover. I dunno why you'd want point (1), but I suppose it's not for me to decide; point (2) is borderline a bug that this change does nothing about, and for point (3) I'm not sure why you'd need to start a preset by typing in the name, and creating a copy is easy enough as just selecting the preset you want to copy, then doing whatever you need to do to the selected mods, and then saving the result to a new preset. I dunno this feels fixing an issue nobody should have. @peppy your thoughts on this thing? I'd say we don't want it. |
I don't see any harm in having it if the complexity overhead is minimal, but also not sure it's required. Since there's already a button explaining how to update the preset, I'd hope that most users can figure out how to remove mods using the existing flow. Additionally, I see less value in adding a "remove" button if there's not also an "add" button. |
Changes
To make it easier for users to remove unwanted mods in a custom mod preset.
By the way should we consider add a
Use current mods
in the context menu? Thus we don't need to open the editor popup to apply mods to a preset.Known Problems
Bindable<Hashset<Mod>>
for that.LocalisableString
for tooltip text is being considered.