Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added request id omit flag #303

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

marcosmol204
Copy link
Contributor

@marcosmol204 marcosmol204 commented Aug 14, 2023

PR for #255 .
I tried to avoid breaking changes.
@rluvaton @yoni-rapoport WDYT?

@request-info
Copy link

request-info bot commented Aug 14, 2023

Thanks for opening this PR! We would appreciate it if you could provide us with more info about your PR 🙏

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: -27.29% ⚠️

Comparison is base (a204201) 90.92% compared to head (dcd1071) 63.63%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #303       +/-   ##
===========================================
- Coverage   90.92%   63.63%   -27.29%     
===========================================
  Files          16        2       -14     
  Lines         595       22      -573     
  Branches       43        3       -40     
===========================================
- Hits          541       14      -527     
+ Misses         53        7       -46     
  Partials        1        1               
Flag Coverage Δ
app ?
generator 63.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant