Add language column in import export #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudigiesler
reviewed
Jan 28, 2025
home/export_content_pages.py
Outdated
| export_lang_code = "" | ||
| for lang_code, lang_dn in get_content_languages().items(): | ||
| if lang_dn == str(page.locale): | ||
| export_lang_code = lang_code |
There was a problem hiding this comment.
Can we not just do page.locale.language_code to get the language code for the current page?
home/import_content_pages.py
Outdated
| @@ -268,7 +268,10 @@ def create_content_page_index_from_row(self, row: "ContentRow") -> None: | |||
| def create_shadow_content_page_from_row( | |||
| self, row: "ContentRow", row_num: int | |||
| ) -> None: | |||
| locale = self.locale_from_display_name(row.locale) | |||
| if row.language_code: | |||
| locale = locale = Locale.objects.get(language_code=row.language_code) | |||
There was a problem hiding this comment.
What if no Locale exists for the language code given in the row? In that case, we should raise an ImportException, similar to how locale_from_display_name does.
| 1. Quit tobacco 🚭 | ||
| _Stop smoking with the help of a guided, 42-day program._ | ||
| 2. Manage your stress 🧘🏽♀️ | ||
| _Learn how to cope with stress and improve your wellbeing._",,,3e5d77f7-4d34-430d-aad7-d9ca01f79732,self_help,,,English,,[],,,,,, |
There was a problem hiding this comment.
Do we need so much and so long content for this test? Maybe we can reduce it to just what is necessary, so that it's easier to see what we're testing here.
home/export_content_pages.py
Outdated
| @@ -208,6 +210,11 @@ def _export_content_page(self, page: ContentPage, structure: str) -> None: | |||
| * We should use the parent slug (which is expected to be unique per | |||
| locale (probably?)) instead of the parent title. | |||
| """ | |||
| export_lang_code = "" | |||
| for lang_code, lang_dn in get_content_languages().items(): | |||
There was a problem hiding this comment.
It's not just content pages that need language codes, it's also content index pages.
rudigiesler
reviewed
Jan 30, 2025
home/import_content_pages.py
Outdated
| @@ -252,7 +259,7 @@ def create_content_page_index_from_row(self, row: "ContentRow") -> None: | |||
| # but optional for the default locale. | |||
| if row.translation_tag or locale != self.default_locale(): | |||
| index.translation_key = row.translation_tag | |||
| locale = self.locale_from_display_name(row.locale) | |||
| # locale = self.locale_from_display_name(row.locale) | |||
There was a problem hiding this comment.
We can remove this line instead of commenting it out
rudigiesler
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Why does this exist?
Solution
_What changed, and does this address the problem? _
Checklist