Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import warning #420

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Import warning #420

wants to merge 18 commits into from
+110 −5

Conversation

Buhle79
Copy link
Contributor

@Buhle79 Buhle79 commented Feb 17, 2025

Purpose

Why does this exist?

Solution

_What changed, and does this address the problem? _

Checklist

  • Added or updated unit tests
  • Added to release notes
  • Updated readme/documentation (if necessary)

@Buhle79
add warnings draft
4e21cbd
@Buhle79
Merge branch 'main' of https://github.com/praekeltfoundation/contentrepo
b2afbb9 
 into import-warning

# Conflicts:
#	home/tests/test_content_import_export.py
jerith
jerith reviewed Feb 17, 2025
View reviewed changes
home/import_content_pages.py Outdated Show resolved Hide resolved
home/import_content_pages.py Outdated Show resolved Hide resolved
@Buhle79 Buhle79 marked this pull request as ready for review February 18, 2025 08:42
jerith
jerith reviewed Feb 19, 2025
View reviewed changes
home/import_helpers.py Outdated Show resolved Hide resolved
home/views.py Outdated Show resolved Hide resolved
@Buhle79
Copy link
Contributor Author

Buhle79 commented Feb 19, 2025

Hi @jerith this task is ready for re look please

jerith
jerith previously approved these changes Feb 20, 2025
View reviewed changes
@Buhle79
Merge branch 'main' of https://github.com/praekeltfoundation/contentrepo
4a05d75 
 into import-warning

# Conflicts:
#	home/import_content_pages.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerith jerith jerith left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Buhle79 @jerith