Skip to content

Commit

Permalink
Merge pull request #50 from pragmaticivan/release-v1.8.0
Browse files Browse the repository at this point in the history
chore: release 1.8.0
  • Loading branch information
pragmaticivan authored Jul 24, 2021
2 parents 7cdbd24 + cbcda95 commit 52acb62
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 2 deletions.
12 changes: 12 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,17 @@
# Changelog

## [1.8.0](https://www.github.com/pragmaticivan/nestjs-otel/compare/v1.7.0...v1.8.0) (2021-07-24)


### Features

* update api metrics to use route match path instead of full route ([ad51bac](https://www.github.com/pragmaticivan/nestjs-otel/commit/ad51bac1b0121257434cc4543853227669f15aca)), closes [#48](https://www.github.com/pragmaticivan/nestjs-otel/issues/48)


### Bug Fixes

* fixes forRootAsync usage ([a390f0e](https://www.github.com/pragmaticivan/nestjs-otel/commit/a390f0e564227b5e9019d1b8da19e4966e3d7ddf))

## [1.7.0](https://www.github.com/pragmaticivan/nestjs-otel/compare/v1.6.0...v1.7.0) (2021-07-14)


Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "nestjs-otel",
"version": "1.7.0",
"version": "1.8.0",
"description": "NestJS OpenTelemetry Library",
"main": "lib/index.js",
"typings": "lib/index",
Expand Down

3 comments on commit 52acb62

@issackr
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit breaks the lib:
const { path } = route; TypeError: Cannot destructure property 'path' of 'route' as it is undefined
at /node-modules/nestjs-otel/lib/middleware/api-metrics.middleware/js:56:21

@pragmaticivan
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@issackr I found that yesterday night. I'm sending a fix soon and writing more tests (missed by not having tests)

@pragmaticivan
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@issackr fixed here: #51

Will be released as 1.8.1 in a few min.

Please sign in to comment.