SUPPORT unknown types #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Define a new thing called HTTP_UNKNOWN - If doesn't fit our defined set of methods, mark as HTTP_UNKNOWN and pass the method type thru to curl unchanged - Get rid of http_method domain standard type enforcement Closes pramsey#159
pramsey
reviewed
Aug 4, 2023
http.c
Outdated
| @@ -1206,6 +1207,11 @@ Datum http_request(PG_FUNCTION_ARGS) | |||
| CURL_SETOPT(g_http_handle, CURLOPT_READDATA, &si_read); | |||
| CURL_SETOPT(g_http_handle, CURLOPT_INFILESIZE, content_size); | |||
| } | |||
| else if (method == HTTP_UNKNOWN) | |||
| { | |||
| /** assume the user knows what they are doing and pass unchanged **/ | |||
There was a problem hiding this comment.
Remove the double ** in the comment.
pramsey
reviewed
Aug 4, 2023
| @@ -1078,8 +1079,8 @@ Datum http_request(PG_FUNCTION_ARGS) | |||
| elog(ERROR, "http_request.method is NULL"); | |||
| method_str = TextDatumGetCString(values[REQ_METHOD]); | |||
There was a problem hiding this comment.
Sorry seeing this just in the patch w/o context, want to confirm we have a null check?
pramsey
reviewed
Aug 4, 2023
http.c
Outdated
| elog(DEBUG2, "pgsql-http: method '%s'", method_str); | ||
| pfree(method_str); | ||
| elog(DEBUG2, "pgsql-http: method_str '%s'", method_str); | ||
| elog(DEBUG2, "pgsql-http: method '%d'", method); |
There was a problem hiding this comment.
Crunch it down to one debug line.
pramsey
reviewed
Aug 4, 2023
http.c
Outdated
| @@ -1225,7 +1231,12 @@ Datum http_request(PG_FUNCTION_ARGS) | |||
| /* If we had a content we do not reach that part */ | |||
| elog(ERROR, "http_request.content is NULL"); | |||
| } | |||
| else if ( method == HTTP_UNKNOWN ){ | |||
| /** assume the user knows what they are doing and pass unchanged **/ | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #159