Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README to refer to register instead of CustomElement #82

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Update README to refer to register instead of CustomElement #82

merged 2 commits into from
Aug 9, 2023

Conversation

bhollis
Copy link
Contributor

@bhollis bhollis commented Aug 8, 2023

It looks like this reference was missed when the example code was switched to the register function.

rschristian
rschristian approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@rschristian rschristian left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, went digging around in the blame and this was missed for 7 years! Appreciate you fixing the grammar too!

dacc8f9

rschristian
rschristian reviewed Aug 9, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@marvinhagemeister marvinhagemeister merged commit b6f6c2e into preactjs:master Aug 9, 2023
1 check failed
@rschristian
Copy link
Member

Thanks for the force merge @marvinhagemeister! I might take a peek at the CI tomorrow, see if I can't get that fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rschristian rschristian rschristian approved these changes

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bhollis @rschristian @marvinhagemeister