Ensure react 19 entry is tested with working imports #4649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoviDeCroock
changed the title
rschristian
approved these changes
Feb 9, 2025
|
|
||
| import { options } from 'preact'; | ||
|
|
||
| const oldVNode = options.vnode; | ||
| options.vnode = vnode => { | ||
| if (typeof vnode.type === 'function') { | ||
| vnode.type._forwarded = true; | ||
| if (typeof vnode.type === 'function' && vnode.ref) { |
There was a problem hiding this comment.
This change probably needs to be mirrored to the CJS copy (in the off chance you didn't already have that change local & just not yet pushed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that
react/server,react/clientand many others keep working when they use the react-19 alias point. This also adds tests so that we won't regress in the future. There are still some issues with the import typings, will take another look soon.